feat: Add pre-commit and apply fixes #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 15, 2022 21:48
General QA uplift: - Forces standard line endings - Replacing tabs with spaces - Removing trailing whitespace - Makefile targets for QA shortcuts Python QA: - sorts imports via isort - applies formatting via black - applies code style fixes suggested by flake8 Terraform QA: - applies terraform fmt - generates documentation
Also bump actions/checkout to latest version
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ludoo
reviewed
Jun 15, 2022
|
I am going to close this, feel free to resubmit PRs one at a time for each individual extra feature, and we can take it from there. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No module or app logic changes are included in this PR, it's purely QA and tooling uplift, in preparation for a follow up solving issues with resource name lengths.
General QA uplift:
Python QA:
Terraform QA:
Future improvements: TF module linting via
tflint