-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAST: CI/CD support for Source Repository and Cloud Build #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
changed the title
WIP: CI/CD support for Source Repository and Cloud Build
CI/CD support for Source Repository and Cloud Build
Jun 8, 2022
juliocc
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
ludoo
changed the title
CI/CD support for Source Repository and Cloud Build
FAST: CI/CD support for Source Repository and Cloud Build
Jun 10, 2022
lcaggio
pushed a commit
that referenced
this pull request
Jun 17, 2022
* add id to outputs * initial cloud build implementation for stage 0 * comments * stage 0 * stage 1, untested * add support for IAM and CB triggers to source repository module * refactor stage 0 to use sourcerepo module * refactor stage 1 to use sourcerepo module * file descriptions * fix gitlab pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to our CI/CD machinery for Source Repositories and Cloud Build Triggers to both stage 0 and 1.
The interface is left unchanged, with just a new
sourcerepos
repository type supported in thecicd_repositories
variables.The implementation is fairly simple as it leverages an improved
source_repository
module to wrap repo, IAM and Cloud Build trigger.I tested the new Cloud Build workflow in stage 0, but did not test stage 1 yet. Code is identical so barring typos it should work the same.