Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on ci, add linting and boilerplate steps #6

Merged
merged 5 commits into from
Sep 9, 2019
Merged

Turn on ci, add linting and boilerplate steps #6

merged 5 commits into from
Sep 9, 2019

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Sep 7, 2019 •
edited
Loading

Preliminary linting step.

@ludoo ludoo changed the title WIP ci, ignore Turn on ci, add linting step Sep 7, 2019
@ludoo
Copy link
Collaborator Author

ludoo commented Sep 7, 2019

Linting step uses the Docker tflint image.

@ludoo ludoo requested a review from averbuks September 7, 2019 04:51
morgante
morgante previously requested changes Sep 7, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason why this repository should use different linters than the standard flow? https://github.com/terraform-google-modules/terraform-google-module-template/blob/master/terraform-google-%7B%7Bcookiecutter.module_name%7D%7D/build/lint.cloudbuild.yaml

morgante
morgante reviewed Sep 7, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is on fabric, I'm fine with divergence.

That being said, I think it'd be cool to upstream the tflint rules into the standard linter as well.

@ludoo
Copy link
Collaborator Author

ludoo commented Sep 7, 2019

Yes, let's experiment with it here for a while, taking it upstream if it's solid will be very easy. Thanks for chiming in so quickly!

@ludoo ludoo requested review from morgante and removed request for morgante September 7, 2019 07:09
@ludoo
Copy link
Collaborator Author

ludoo commented Sep 7, 2019

Added a simple step to check boilerplate (and spotted 3 files missing it). The script is simple, but it reflects what our presubmit checks usually do, so it should be good enough (and less prone to breakage).

@ludoo ludoo dismissed morgante’s stale review September 7, 2019 07:10

chatted offline

@ludoo ludoo changed the title Turn on ci, add linting step Turn on ci, add linting and boilerplate steps Sep 7, 2019
@ludoo ludoo merged commit 3442156 into master Sep 9, 2019
@ludoo ludoo deleted the ci-linting branch September 9, 2019 09:58
juliodiez added a commit that referenced this pull request Feb 10, 2023
@juliodiez
Merge pull request #6 from juliodiez/master
462ca56 
Sync branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante left review comments

@averbuks averbuks averbuks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludoo @morgante @averbuks