Update net-lb-app-ext security_settings variables #2783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub PR Description:
I am following the Medium article Private GCS Bucket Access Through Google Cloud CDN to create a Google Cloud CDN service using Terraform, with the backend being a private GCS bucket. However, I encountered an issue where the
variables-backend-service.tf
file requires thesecurity_settings
attribute to include bothclient_tls_policy
andsubject_alt_names
.If I set these two parameters, I receive the following error:
However, according to the Google Cloud Compute Engine API documentationhere,
clientTlsPolicy
only applies to a global BackendService with theloadBalancingScheme
set toINTERNAL_SELF_MANAGED
. But the created GCS backend is for global internet use, so this parameter should not be required but optional. Similarly,subjectAltNames
should also be optional as per the Google Cloud Compute Engine API documentation. This PR aims to address this issue by makingclient_tls_policy
andsubject_alt_names
optional parameters in thegoogle-beta
provider, aligning with the actual usage and requirements of Google Cloud services. For reference, theclient_tls_policy
andsubject_alt_names
parameters are also optional in thegoogle-beta
provider as documented here.Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py
Sorry, i don't know how to test, but with this change i success create GLB/ENG