Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for perma-diff when using PSC NEGs. #2772

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix for perma-diff when using PSC NEGs. #2772

merged 1 commit into from
Dec 17, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 17, 2024

Provider issue: hashicorp/terraform-provider-google#20576

Without this, you get non-empty plan after creating PSC Neg:

  # module.ilb-l7.google_compute_region_network_endpoint_group.psc["my-neg"] must be replaced
-/+ resource "google_compute_region_network_endpoint_group" "psc" {
      ~ id                    = "<redacted>/networkEndpointGroups/psc-consumer-my-neg" -> (known after apply)
        name                  = "psc-consumer-my-neg"
      ~ region                = "https://www.googleapis.com/compute/v1/projects/<redacted>/regions/europe-west4" -> "europe-west4"
      ~ self_link             = "https://www.googleapis.com/compute/v1/projects/<redacted>/regions/europe-west4/networkEndpointGroups/psc-consumer-my-neg" -> (known after apply)
        # (6 unchanged attributes hidden)

      - psc_data { # forces replacement
            # (1 unchanged attribute hidden)
        }
    }


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn enabled auto-merge (rebase) December 17, 2024 13:28
@wiktorn wiktorn merged commit 3337f0b into master Dec 17, 2024
18 checks passed
@wiktorn wiktorn deleted the wiktorn-psc-fix branch December 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants