Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of GKE Nodepool SA Display Name #2734

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

robrankin
Copy link
Contributor

@robrankin robrankin commented Nov 26, 2024

When creating a custom nodepool SA, the display name can exceed the maximum length allowed of 100.

This PR allows for setting a custom display name on the nodepool SA, but keeps the default construction if display_name is not specified.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass
❯ pytest -k 'gke-nodepool' tests/examples
==== test session starts =====
platform darwin -- Python 3.11.6, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/robertrankin/Development/Terraform/rr2_cloud-foundation-fabric/tests
configfile: pytest.ini
plugins: xdist-3.6.1
collected 625 items / 619 deselected / 6 selected

tests/examples/test_plan.py ......                                                                                                                                                                                                           [100%]

==== 6 passed, 619 deselected in 118.79s (0:01:58)

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@ludoo ludoo enabled auto-merge (squash) November 27, 2024 15:58
@ludoo ludoo merged commit 20a1689 into GoogleCloudPlatform:master Nov 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants