Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workload_metadata_config in Standard GKE clusters #2716

Merged

Conversation

Tirthankar17
Copy link
Contributor

@Tirthankar17 Tirthankar17 commented Nov 18, 2024

This PR is raised for this closed issue.

Currently the support for workload_metadata_config in GKE standard cluster is missing. We want to enable workload identity in the clusters and ensure that GKE Metadata server is enabled standard GKE clusters. The nodepool module does support workload_metadata_config but that is not unanimously used for all standard GKE clusters.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Nov 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Tirthankar17 Tirthankar17 changed the title Gke standard feature request Add support for workload_metadata_config in Standard GKE clusters Nov 18, 2024
@juliocc juliocc enabled auto-merge (squash) November 20, 2024 09:22
@juliocc juliocc merged commit a90fe65 into GoogleCloudPlatform:master Nov 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants