Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify usage of top level folders short_name #2693

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Nov 15, 2024

  1. Make short_name optional (use key name/filename if not provided)
  2. Disable automation by default
  3. Remove enable key from top_level_folders automation field

The idea here is to have make the following work

top_level_folders = {
  test = {
    name       = "test folder"
  }
}

Today this would enable automation, and fail because we're not providing a short name. With this change, the code above works and does not enable automation. IMO this makes more sense since the user is not mentioning automation at all

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, can you also edit the schema?

@ludoo
Copy link
Collaborator

ludoo commented Nov 15, 2024

I'm also curious about which IAM bindings we're dropping in tests with this PR.

@juliocc juliocc force-pushed the jccb/top-level-folder-automation-default branch from 78d2072 to f24c48e Compare November 15, 2024 11:09
@juliocc
Copy link
Collaborator Author

juliocc commented Nov 15, 2024

very nice, can you also edit the schema?

Done. I'm not familiar with the syntax, can you double check it?

I'm also curious about which IAM bindings we're dropping in tests with this PR.

Apparently it's not just some IAM bindings. All the automation resources for the sandbox were missing before. PTAL

@juliocc juliocc merged commit 7b2a342 into fast-dev Nov 15, 2024
18 checks passed
@juliocc juliocc deleted the jccb/top-level-folder-automation-default branch November 15, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants