Fix "inconsistent conditional result types" error in modules/vpc-sc

[joelvoss]

This PR fixes the issue described in issue #2675. I've also adapted one of the example based tests so that the incorrect behavior is checked in the future.

---

Checklist

I applicable, I acknowledge that I have:

• Read the contributing guide
• Ran terraform fmt on all modified files
• Regenerated the relevant README.md files using tools/tfdoc.py
• Made sure all relevant tests pass

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ludoo]

Thanks, I just wonder why you edit the ingress policy examples but the change to the factory code is for egress. :)

[joelvoss]

I thought it would be enough to just customize the ingress part of the example-based test. I can also extend the egress part as well if you like.

The adjustments in the code affect both ingress and egress.

[ludoo]

Thanks for clarifying. My preference would be to leave the current examples as is, and add an extra set of YAML/code rules to cover this case. It makes it easier to assess changes.

[joelvoss]

Thanks for clarifying. My preference would be to leave the current examples as is, and add an extra set of YAML/code rules to cover this case. It makes it easier to assess changes.

No problem. I have reverted the changes to the current examples and added an extra set of YAML/code rules to cover this case instead.

[ludoo]

thanks a lot for this!