Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enable_object_retention argument #2657

Merged
merged 3 commits into from
Nov 5, 2024
Merged

add enable_object_retention argument #2657

merged 3 commits into from
Nov 5, 2024

Conversation

kejti23
Copy link
Contributor

@kejti23 kejti23 commented Nov 4, 2024

Checklist

I applicable, I acknowledge that I have:

  • [ X] Read the contributing guide
  • [ X] Ran terraform fmt on all modified files
  • [X ] Regenerated the relevant README.md files using tools/tfdoc.py
  • [X ] Made sure all relevant tests pass

@kejti23 kejti23 marked this pull request as ready for review November 5, 2024 07:24
@kejti23
Copy link
Contributor Author

kejti23 commented Nov 5, 2024

Hi @juliocc

Is anything missing from my side, so the branch can be merged?

btw
Thanks a lot for your previous help.

juliocc
juliocc approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @kejti23

LGTM

@juliocc juliocc enabled auto-merge (squash) November 5, 2024 13:31
auto-merge was automatically disabled November 5, 2024 15:36

Head branch was pushed to by a user without write access

@kejti23 kejti23 force-pushed the add-enable_object_retention-argument branch from 1c56c72 to 560a9a5 Compare November 5, 2024 15:36
@juliocc juliocc merged commit caddfef into GoogleCloudPlatform:master Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kejti23 @juliocc