Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to attach multiple snapshot schedule to disks #2639

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

shujaatsscripts
Copy link
Contributor

Currently only one snapshot schedule is allowed to attach to the disk. The variable take a string.

This PR added the option to give the list of snapshot schedules to attach to the disk/boot disk. This option is not allowed through GCP console but its available in terraform and gcloud cli.

Example: If we need to take snapshots both daily and weekly, we need to attach 2 snapshot schedule to one disk.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Oct 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo ludoo enabled auto-merge (squash) October 28, 2024 17:06
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, very clean PR

@ludoo ludoo merged commit 6db881d into GoogleCloudPlatform:master Oct 28, 2024
14 checks passed
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants