Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate blueprints/data-solutions/vertex-mlops to google_workbench_instance #2632

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Oct 20, 2024

Attempt to replace deprecated google_notebooks_instance with google_workbench_instance.

It's not yet deploying properly, as container is not starting due to error:

nerdctl[2925]: time="2024-10-20T08:23:54Z" level=fatal msg="failed to verify networking settings: failed to create default network: subnet 10.4.0.0/24 overlaps with other one on this address space"

Not sure what's wrong with containerd/nerdctl config here.

@lcaggio , @gioconte - any hints?

Closes: #2173


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@lcaggio
Copy link
Collaborator

lcaggio commented Oct 22, 2024

@javiergp wrote the initial version. Any insight on the question above?

@javiergp
Copy link
Collaborator

This is a known issue (see b/357666620). As a workaround, you can modify the subnet to a differente range.

@wiktorn
Copy link
Collaborator Author

wiktorn commented Oct 22, 2024

This is a known issue (see b/357666620). As a workaround, you can modify the subnet to a differente range.

Thanks a lot, wouldn't suspect that the solution is so easy :-)

@wiktorn wiktorn marked this pull request as ready for review October 22, 2024 18:16
@wiktorn wiktorn enabled auto-merge (rebase) October 26, 2024 18:58
@wiktorn wiktorn requested review from javiergp and lcaggio October 28, 2024 08:41
@wiktorn wiktorn force-pushed the wiktorn-vertex-mlops-deprecated-notebooks branch from f584c80 to f4d3b4f Compare November 4, 2024 08:28
Copy link
Collaborator

@lcaggio lcaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it!

blueprints/data-solutions/vertex-mlops/vertex.tf Outdated Show resolved Hide resolved
@wiktorn wiktorn force-pushed the wiktorn-vertex-mlops-deprecated-notebooks branch from f4d3b4f to ebe19c3 Compare November 4, 2024 09:22
@wiktorn wiktorn merged commit 4ab9c74 into GoogleCloudPlatform:master Nov 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate blueprints/data-solutions/vertex-mlops to google_workbench_instance
3 participants