Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manage existing SSM instance #2595

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Allow manage existing SSM instance #2595

merged 7 commits into from
Sep 27, 2024

Conversation

lnesteroff
Copy link
Collaborator

Modified the secure-source-manager-instance module to allow management of an existing instance (eg create repos and manage IAM). Also removed the location attr from the repositories var as it needs to be the same as the instance, so this would save having to enter a location for each repo being created.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for small comment. See inline

modules/secure-source-manager-instance/iam.tf Outdated Show resolved Hide resolved
@lnesteroff lnesteroff requested a review from juliocc September 27, 2024 09:39
@juliocc juliocc merged commit 163a0ea into master Sep 27, 2024
18 checks passed
@juliocc juliocc deleted the lnesteroff/ssm-repos branch September 27, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants