Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Module CMEK: added CloudRun #2587

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Project Module CMEK: added CloudRun #2587

merged 1 commit into from
Sep 20, 2024

Conversation

artemBogdantsev
Copy link
Contributor

Added CloudRun to the list so that CloudRun service agent gets encryptor/decryptor role on CMEK

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass
  • Tested on customer's PROD env 😁

@artemBogdantsev
Project Module CMEK: added CloudRun
7d6594e 
Added CloudRun to the list so that CloudRun service agent gets encryptor/decryptor role on CMEK
ludoo
ludoo approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@ludoo ludoo enabled auto-merge (squash) September 20, 2024 08:19
@ludoo ludoo merged commit 4bacbf5 into GoogleCloudPlatform:master Sep 20, 2024
14 checks passed
@artemBogdantsev artemBogdantsev deleted the patch-3 branch September 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemBogdantsev @ludoo