Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure source manager #2569

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Secure source manager #2569

merged 3 commits into from
Sep 19, 2024

Conversation

apichick
Copy link
Collaborator

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@apichick apichick force-pushed the ssm branch 10 times, most recently from 2f690ca to 24fd120 Compare September 15, 2024 14:59
sruffilli
sruffilli approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@sruffilli sruffilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Out of curiosity, is any whitelist still required to deploy an SSM?

modules/secure-source-manager-instance/README.md Outdated Show resolved Hide resolved
@ludoo
Copy link
Collaborator

ludoo commented Sep 16, 2024

Can you split IAM into variables-iam.tf and iam.tf and implement the full interface?

@apichick apichick enabled auto-merge (squash) September 19, 2024 10:18
@apichick
Copy link
Collaborator Author

Yes, whielisting is required

@apichick apichick merged commit 0f28d26 into master Sep 19, 2024
18 checks passed
@apichick apichick deleted the ssm branch September 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruffilli sruffilli sruffilli approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apichick @ludoo @sruffilli