Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New looker core module #2565

Merged
merged 14 commits into from
Sep 20, 2024
Merged

New looker core module #2565

merged 14 commits into from
Sep 20, 2024

Conversation

simonebruzzechesse
Copy link
Collaborator

@simonebruzzechesse simonebruzzechesse commented Sep 13, 2024

New looker core module.

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

fix #2426

@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/looker-core branch 2 times, most recently from c98600b to 2952fd8 Compare September 13, 2024 11:54
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few small comments

modules/looker-core/README.md Outdated Show resolved Hide resolved
modules/looker-core/variables.tf Outdated Show resolved Hide resolved
modules/looker-core/variables.tf Outdated Show resolved Hide resolved
modules/looker-core/main.tf Show resolved Hide resolved
@wiktorn
Copy link
Collaborator

wiktorn commented Sep 17, 2024

E2E test run

@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/looker-core branch 2 times, most recently from f9fedcd to 5491185 Compare September 20, 2024 07:52
@simonebruzzechesse simonebruzzechesse merged commit 1f2bdd0 into master Sep 20, 2024
18 checks passed
@simonebruzzechesse simonebruzzechesse deleted the bruzz/looker-core branch September 20, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Looker (Google Cloud Core) module
2 participants