-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New looker core module #2565
Merged
Merged
New looker core module #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonebruzzechesse
force-pushed
the
bruzz/looker-core
branch
2 times, most recently
from
September 13, 2024 11:54
c98600b
to
2952fd8
Compare
wiktorn
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few small comments
wiktorn
reviewed
Sep 17, 2024
simonebruzzechesse
force-pushed
the
bruzz/looker-core
branch
2 times, most recently
from
September 20, 2024 07:52
f9fedcd
to
5491185
Compare
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
simonebruzzechesse
force-pushed
the
bruzz/looker-core
branch
from
September 20, 2024 09:49
5491185
to
68d3370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New looker core module.
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py
fix #2426