Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAST stages to support multi-tenant resman #2549

Closed
wants to merge 2 commits into from

Conversation

ZZelle
Copy link

@ZZelle ZZelle commented Sep 2, 2024

The FAST stage 1-resman fails in a tenant for multiple reasons:

  • it tries to create top level folders with the organization as parent instead of the local.root_node
  • it uses the tag "project-factory" without creating it (it's done correctly without multi-tenancy)
  • the stage 1-tenant-factory generates 0-bootstrap.auto.tfvars.json without some data required by 1-resman

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Sep 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Sep 10, 2024

@ZZelle can you check the linting issues and sign the CLA?

@ludoo ludoo mentioned this pull request Sep 18, 2024
@ludoo
Copy link
Collaborator

ludoo commented Sep 18, 2024

Superseded by #2579

@ludoo ludoo closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants