Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full examples for CMEK examples #2546

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Aug 31, 2024

Fix E2E tests by ensuring that necessary resources already exists.

For CMEK examples - make them fully verbose and end-to-end.

For some, still explicit depends_on is required:

  • cloud functions require additional grants to actually work with default service account, I'm considering moving this grant to setup_module

This is alternate fix to the one proposed in #2524.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn marked this pull request as draft August 31, 2024 21:42
@wiktorn wiktorn force-pushed the wiktorn-e2e_grants_fix-full-cmek-examples branch from 943b054 to 773b24c Compare August 31, 2024 21:49
@wiktorn
Copy link
Collaborator Author

wiktorn commented Aug 31, 2024

@juliocc Can you take a look at modules/alloydb here before I move forward with all other modules?

@wiktorn
Copy link
Collaborator Author

wiktorn commented Sep 1, 2024

E2E run

@wiktorn wiktorn marked this pull request as ready for review September 2, 2024 07:20
@juliocc
Copy link
Collaborator

juliocc commented Sep 3, 2024

@juliocc Can you take a look at modules/alloydb here before I move forward with all other modules?

This looks much better.

@wiktorn wiktorn force-pushed the wiktorn-e2e_grants_fix-full-cmek-examples branch from 216acf9 to 398f73e Compare September 3, 2024 16:43
@wiktorn
Copy link
Collaborator Author

wiktorn commented Sep 4, 2024

I think this is as good as it gets. I split changes into two commits - one adding dependencies in outputs in modules, and the other fixing the tests themselves.

Ready for thorough review

@wiktorn wiktorn requested a review from juliocc September 4, 2024 09:54
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@wiktorn wiktorn merged commit 44a4268 into GoogleCloudPlatform:master Sep 4, 2024
14 checks passed
@wiktorn wiktorn deleted the wiktorn-e2e_grants_fix-full-cmek-examples branch September 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants