Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for google provider 6.x #2536

Merged
merged 17 commits into from
Sep 5, 2024
Merged

Add support for google provider 6.x #2536

merged 17 commits into from
Sep 5, 2024

Conversation

sruffilli
Copy link
Collaborator


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@ludoo
Copy link
Collaborator

ludoo commented Aug 28, 2024

this should wait for the release

@sruffilli sruffilli marked this pull request as ready for review August 28, 2024 16:29
@juliocc
Copy link
Collaborator

juliocc commented Aug 29, 2024

lgtm. As @ludoo said, I'd do a release just before merging this

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update release comment in versions.tf to say

# Fabric release: v35.0.0-pre

@wiktorn
Copy link
Collaborator

wiktorn commented Aug 31, 2024

Before moving forward with this - there is a few resources that added deletion_policy:

  • folder
  • cloud run service v2

Plus others, and they do default to true. It means, that for all E2E tests, we need to explicitly set to false, or take make it default to true in modules.

You can check where we are at this moment in this run

@wiktorn
Copy link
Collaborator

wiktorn commented Sep 1, 2024

In #2502 @juliocc added deletion_policy to modules/project with default value DELETE.

Shall we do the same for cloudrun-v2 and folder?

@juliocc
Copy link
Collaborator

juliocc commented Sep 1, 2024

In #2502 @juliocc added deletion_policy to modules/project with default value DELETE.

Shall we do the same for cloudrun-v2 and folder?

@sruffilli already added support to modules/folder and modules/cloud-run-v2 in this same PR:

And I just pushed a small commit for google_cloud_run_v2_job resources.

@wiktorn
Copy link
Collaborator

wiktorn commented Sep 1, 2024

In #2502 @juliocc added deletion_policy to modules/project with default value DELETE.
Shall we do the same for cloudrun-v2 and folder?

@sruffilli already added support to modules/folder and modules/cloud-run-v2 in this same PR:

And I just pushed a small commit for google_cloud_run_v2_job resources.

Yep, but as of now, we have with default value of null, that is using provider default (enforce deletion protection), which is different from what we do in modules/project where we override provider default.

@juliocc
Copy link
Collaborator

juliocc commented Sep 1, 2024

Yep, but as of now, we have with default value of null, that is using provider default (enforce deletion protection), which is different from what we do in modules/project where we override provider default.

I see. For project I tried to keep to behavior we've always had because it's a core module and didn't want to break everyone's code. For folder we should probably do the same.

For cloud-run-v2 I'm I don't know. It's not used that much so I think we can keep the provider's default and document the change. wdyt?

@sruffilli sruffilli enabled auto-merge (squash) September 5, 2024 10:28
@sruffilli sruffilli disabled auto-merge September 5, 2024 10:28
@sruffilli sruffilli enabled auto-merge (squash) September 5, 2024 10:29
@sruffilli sruffilli merged commit 7f8a02a into master Sep 5, 2024
18 checks passed
@sruffilli sruffilli deleted the sruffilli/provider6 branch September 5, 2024 10:36
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:modules on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants