-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed folders support to gcs
module
#2530
Conversation
gcs
modulesgcs
module
gcs
modulegcs
module
805ca37
to
74d380f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, my only nit is on Keys must end in /
, can we interpolate it and have more readable keys? ignore me ofc if the current approach makes more sense
Removed the need for the trailing / |
gcs
modulegcs
module
9e6370e
to
cef877d
Compare
iam_by_principals