Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed folders support to gcs module #2530

Merged
merged 14 commits into from
Aug 28, 2024
Merged

Add managed folders support to gcs module #2530

merged 14 commits into from
Aug 28, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Aug 27, 2024

  • Add support for managed folders
  • Add support for RPO
  • Make STANDARD the default storage class
  • Add iam_by_principals

@juliocc juliocc changed the title Add managed folders suports togcs modules Add managed folders suports togcs module Aug 27, 2024
@juliocc juliocc changed the title Add managed folders suports togcs module Add managed folders suports to gcs module Aug 27, 2024
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, my only nit is on Keys must end in /, can we interpolate it and have more readable keys? ignore me ofc if the current approach makes more sense

@juliocc
Copy link
Collaborator Author

juliocc commented Aug 27, 2024

very nice, my only nit is on Keys must end in /, can we interpolate it and have more readable keys? ignore me ofc if the current approach makes more sense

Removed the need for the trailing /

@juliocc juliocc enabled auto-merge (squash) August 27, 2024 18:16
@juliocc juliocc changed the title Add managed folders suports to gcs module Add managed folders support to gcs module Aug 27, 2024
@juliocc juliocc merged commit f57635d into master Aug 28, 2024
18 checks passed
@juliocc juliocc deleted the jccb/gcs-updates branch August 28, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants