Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMEK typo in project module. Part 2 :) #2518

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix CMEK typo in project module. Part 2 :) #2518

merged 1 commit into from
Aug 23, 2024

Conversation

artemBogdantsev
Copy link
Contributor

Yet another typo was found

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@artemBogdantsev
project-module-cmek
1022a30 
Yet another typo was found
ludoo
ludoo approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

@ludoo ludoo enabled auto-merge (squash) August 23, 2024 17:05
@artemBogdantsev
Copy link
Contributor Author

@ludoo thank you as well for the new CMEK part in the project module. You saved me a lot of time 😁

@ludoo ludoo merged commit 1331e56 into GoogleCloudPlatform:master Aug 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemBogdantsev @ludoo