Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FAST project factory and supporting documentation #2505

Merged
merged 30 commits into from
Aug 20, 2024
Merged

Refactor FAST project factory and supporting documentation #2505

merged 30 commits into from
Aug 20, 2024

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Aug 18, 2024 •
edited
Loading

This PR

  • moves the FAST project factory to a stage 2
  • adds a set of sample data files that shows how to implement Teams
  • refactors the documentation to explain the data files and pf features
  • improves the wiring between resman and pf stages to support better substitution (folder ids, host project ids, subnets, etc.)
  • implements external substitutions in resman top-level folders
  • implements internal and external substitutions in the project factory module
  • improves pf tests

The PR answers recurring questions on how to implement teams, or generally use the project factory like those in discussion #1830

@ludoo ludoo marked this pull request as ready for review August 19, 2024 10:28
@ludoo ludoo changed the title [WIP] Refactor FAST project factory and supporting documentation Refactor FAST project factory and supporting documentation Aug 19, 2024
wiktorn
wiktorn approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good read :-)

fast/stages/1-resman/main.tf Outdated Show resolved Hide resolved
fast/stages/1-resman/top-level-folders.tf Outdated Show resolved Hide resolved
fast/stages/1-resman/schemas/folder.schema.json Outdated Show resolved Hide resolved
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Aug 19, 2024
juliocc
juliocc reviewed Aug 20, 2024
View reviewed changes
fast/stages/1-resman/README.md Outdated Show resolved Hide resolved
fast/stages/1-resman/branch-networking.tf Outdated Show resolved Hide resolved
fast/stages/2-project-factory/README.md Outdated Show resolved Hide resolved
fast/stages/2-project-factory/README.md Outdated Show resolved Hide resolved
fast/stages/2-project-factory/README.md Show resolved Hide resolved
fast/stages/2-project-factory/README.md Show resolved Hide resolved
fast/stages/2-project-factory/README.md Show resolved Hide resolved
fast/stages/2-project-factory/main.tf Outdated Show resolved Hide resolved
@ludoo ludoo enabled auto-merge (squash) August 20, 2024 14:09
@ludoo ludoo disabled auto-merge August 20, 2024 14:30
@ludoo ludoo enabled auto-merge (squash) August 20, 2024 16:25
@ludoo ludoo merged commit ad5de9b into master Aug 20, 2024
18 checks passed
@ludoo ludoo deleted the ludo/pf-stage-2 branch August 20, 2024 16:45
@lyricnz lyricnz mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludoo @juliocc @wiktorn