Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the google_tags_location_tag_binding Terraform resource to bind tags on KMS key rings #2501

Conversation

arnodasilva
Copy link
Contributor

@arnodasilva arnodasilva commented Aug 14, 2024

The current version of the KMS Terraform module uses the `google_tags_tag_binding` resource to bind tags to KMS key rings. However, according to the Terraform documentation, this resource is only applicable to projects, folders, and organizations. For non-global resources, such as KMS key rings, the correct resource to use is `google_tags_location_tag_binding`.

Moreover, through multiple tests on a corporate Terraform project, tag bindings using google_tags_location_tag_binding have been successful, whereas attempts with google_tags_tag_binding have not worked.

--- **Checklist**

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Aug 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@arnodasilva arnodasilva force-pushed the arnodasilva/fix-kms-keyrings-tag-bindings branch 2 times, most recently from cefa36b to 6832bf5 Compare August 14, 2024 19:56
@arnodasilva arnodasilva force-pushed the arnodasilva/fix-kms-keyrings-tag-bindings branch from 6832bf5 to b32238f Compare August 16, 2024 19:03
@ludoo
Copy link
Collaborator

ludoo commented Aug 20, 2024

Thanks for spotting this!

@ludoo ludoo enabled auto-merge (squash) August 20, 2024 05:34
@ludoo ludoo merged commit dff209f into GoogleCloudPlatform:master Aug 20, 2024
14 checks passed
@arnodasilva arnodasilva deleted the arnodasilva/fix-kms-keyrings-tag-bindings branch August 20, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants