Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for CloudSQL #2486

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix failing tests for CloudSQL #2486

merged 2 commits into from
Aug 8, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Aug 8, 2024

Adding dependency on the IAM grant, because on destroy, if the grant is removed before instance is deleted, instance deletion fails 🤷:

Error: Error, failed to delete instance db: Error waiting for Delete Instance: 

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn enabled auto-merge (rebase) August 8, 2024 18:00
@wiktorn wiktorn merged commit 251339d into master Aug 8, 2024
17 checks passed
@wiktorn wiktorn deleted the wiktorn-fix-cloudsql-cmek branch August 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants