Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC-SC as separate FAST stage 1 #2460

Merged
merged 20 commits into from
Aug 2, 2024
Merged

VPC-SC as separate FAST stage 1 #2460

merged 20 commits into from
Aug 2, 2024

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Aug 1, 2024

This PR removes VPC-SC functionality from the 2-level Security stage, and moves it to a new 1-level dedicated stage that only does VPC-SC.

This allows decoupling VPC-SC from KMS and other resources we might add in the future, and allows applying VPC-SC right after bootstrap in order to immediately switch to enforced mode protection.

Our default perimeter design also changed to a single perimeter, to more closely mimick what we usually do in recent times, where we privilege coarser granularity and immediate enforcement for new organizations, vs finer granularity and a longer delay before enforcement (or no enforcement ever) due to the additional complexity and operational burden.

@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Aug 1, 2024
@ludoo ludoo changed the title WIP: vpc-sc as separate stage 1 VPC-SC as separate FAST stage 1 Aug 1, 2024
@ludoo ludoo marked this pull request as ready for review August 1, 2024 08:18
@ludoo ludoo requested a review from juliocc August 1, 2024 08:18
fast/stages/1-vpc-sc/variables.tf Outdated Show resolved Hide resolved
fast/stages/1-vpc-sc/variables.tf Outdated Show resolved Hide resolved
fast/stages/1-vpc-sc/variables.tf Outdated Show resolved Hide resolved
fast/stages/1-vpc-sc/README.md Outdated Show resolved Hide resolved
@ludoo ludoo merged commit 345716e into master Aug 2, 2024
17 checks passed
@ludoo ludoo deleted the ludo/fast-resman-ng-1 branch August 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:FAST on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants