-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPC-SC as separate FAST stage 1 #2460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
added
the
incompatible change
Pull request that breaks compatibility with previous version
label
Aug 1, 2024
…m/cloud-foundation-fabric into ludo/fast-resman-ng-1
juliocc
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes VPC-SC functionality from the 2-level Security stage, and moves it to a new 1-level dedicated stage that only does VPC-SC.
This allows decoupling VPC-SC from KMS and other resources we might add in the future, and allows applying VPC-SC right after bootstrap in order to immediately switch to enforced mode protection.
Our default perimeter design also changed to a single perimeter, to more closely mimick what we usually do in recent times, where we privilege coarser granularity and immediate enforcement for new organizations, vs finer granularity and a longer delay before enforcement (or no enforcement ever) due to the additional complexity and operational burden.