Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong expression in compute-mig module #2447

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

bz-canva
Copy link
Contributor

Fixed an obvious error.

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: Unsupported attribute
│ 
│   on .terraform/modules/ci-c3d-highcpu-60-build-canva.compute_mig/modules/compute-mig/autoscaler.tf line 222, in resource "google_compute_region_autoscaler" "default":
│  222:         schedule              = schedule.cron_schedule
│ 
│ This object does not have an attribute named "cron_schedule".

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Jul 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Jul 25, 2024

Thanks!

@ludoo ludoo enabled auto-merge (squash) July 25, 2024 05:16
@ludoo ludoo changed the title Fix wrong expression Fix wrong expression in compute-mig module Jul 25, 2024
@ludoo ludoo merged commit e6ebfbc into GoogleCloudPlatform:master Jul 25, 2024
13 checks passed
@bz-canva
Copy link
Contributor Author

Hi Thanks @ludoo ! Is it possible to backport this change to v32.0.0? https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/v32.0.0

@bz-canva bz-canva deleted the patch-1 branch July 26, 2024 00:35
@ludoo
Copy link
Collaborator

ludoo commented Jul 26, 2024

Hi Thanks @ludoo ! Is it possible to backport this change to v32.0.0? https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/v32.0.0

You mean release a v32.0.1 with just this change?

@bz-canva
Copy link
Contributor Author

You mean release a v32.0.1 with just this change?

Yes plz if possible.

ludoo pushed a commit that referenced this pull request Jul 26, 2024
@ludoo
Copy link
Collaborator

ludoo commented Jul 26, 2024

@bz-canva
Copy link
Contributor Author

@ludoo Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants