Reintroduce docker image path output in AR module #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
approved these changes
Jul 20, 2024
|
Thanks for fixing it |
|
When we change attribute names for a core resource, there might be external users who still are dependent upon image_path instead of docker_image_path. Shouldn't this change be highlighted in breaking changes document somewhere? |
ludoo
added
the
incompatible change
|
@shakeel we usually mark incompatible changes so they are flagged once we generate the changelog. I just did it, and will refresh the changelog shortly, thanks for flagging this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2432