Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cloudbuild service account email #2421

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

nathou
Copy link
Contributor

@nathou nathou commented Jul 11, 2024

The correct format for this service account is documented in https://cloud.google.com/build/docs/cloud-build-service-account


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The correct format for the service account is documented in
https://cloud.google.com/build/docs/cloud-build-service-account
@wiktorn
Copy link
Collaborator

wiktorn commented Jul 11, 2024

Thank you for reporting and fixing!

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud build service account only exists for legacy projects.

https://cloud.google.com/build/docs/cloud-build-service-account-updates

Can you point to the documentation that explains your change?

@ludoo
Copy link
Collaborator

ludoo commented Jul 11, 2024

@wiktorn are you sure this is ok?

@juliocc
Copy link
Collaborator

juliocc commented Jul 11, 2024

This is correct. Cloud Build has two service agents according to the docs:
image

Merging this, but it will be deprecated by my service agents PR ;)

@juliocc juliocc merged commit 454a30b into GoogleCloudPlatform:master Jul 11, 2024
13 checks passed
@nathou nathou deleted the fix-build-sa branch July 11, 2024 13:35
@nathou
Copy link
Contributor Author

nathou commented Jul 11, 2024

Yes, I know this is a legacy service agent, but there are still existing projects using it. Thanks!

@ludoo
Copy link
Collaborator

ludoo commented Jul 11, 2024

This is correct. Cloud Build has two service agents
Merging this, but it will be deprecated by my service agents PR ;)

ok, perfect, I was going by the "we don't have a cb service agent anymore", which is true but only for new projects using default org policies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants