Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAST] Housekeeping in CICD workflow templates and extra stage #2412

Merged
merged 6 commits into from
Jul 8, 2024
Merged

[FAST] Housekeeping in CICD workflow templates and extra stage #2412

merged 6 commits into from
Jul 8, 2024

Conversation

jayBana
Copy link
Collaborator

@jayBana jayBana commented Jul 8, 2024

Made a number of minor changes to CICD workflow templates and extra stage:

  • Updated GitHub workflow template in assets to be inline with the rest of the templates in the repo. The asset from here is used when creating GitHub repos using the "0-cicd-github" extra stage
  • Housekeeping in line with previous PRs

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@jayBana jayBana added the on:FAST label Jul 8, 2024
@jayBana jayBana requested a review from ludoo July 8, 2024 12:18
ludoo
ludoo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@juliocc juliocc merged commit a514ce0 into master Jul 8, 2024
17 checks passed
@juliocc juliocc deleted the jaybana/fast_cicd_templates_update branch July 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayBana @ludoo @juliocc