-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAST] Add basic NGFW enterprise stage #2410
Conversation
fast/stages/2-networking-a-simple/data/firewall-policy-rules/dev/ingress.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving with a couple comments, we can discuss live if you want how/if to implement them (Julio also has comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The code is very clean and concise.
My only concern is the generous use of try
as they tend to hide errors. Can you do a quick pass and remove those that are not necessary?
A few notes:
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py