Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for external SPGs to net-firewall-policy #2409

Merged
merged 5 commits into from
Jul 6, 2024
Merged

Adds support for external SPGs to net-firewall-policy #2409

merged 5 commits into from
Jul 6, 2024

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Jul 6, 2024 •
edited
Loading

  • Adds support to reference external SPGs in factories in net-firewall-policy
  • Adds missing tls_inspect argument to hierarchical and global network firewall policies
  • Fixes regional firewall policy rules, removing security profile groups and ngfw actions (given they're not supported)
  • Updates copyright

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@LucaPrete LucaPrete requested review from ludoo and sruffilli July 6, 2024 07:06
ludoo
ludoo approved these changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo and I would redo the try/lookup

modules/net-firewall-policy/README.md Outdated Show resolved Hide resolved
modules/net-firewall-policy/README.md Outdated Show resolved Hide resolved
modules/net-firewall-policy/net-global.tf Outdated Show resolved Hide resolved
modules/net-firewall-policy/hierarchical.tf Show resolved Hide resolved
@LucaPrete LucaPrete enabled auto-merge (squash) July 6, 2024 10:22
@LucaPrete LucaPrete disabled auto-merge July 6, 2024 10:22
@LucaPrete LucaPrete enabled auto-merge (squash) July 6, 2024 10:23
@LucaPrete LucaPrete merged commit 1bd3380 into master Jul 6, 2024
17 checks passed
@LucaPrete LucaPrete deleted the fwPolicyFactoryNgfw branch July 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@sruffilli sruffilli Awaiting requested review from sruffilli

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaPrete @ludoo