Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding placement_policy for GKE nodepools (ex: GPU compact placement or TPU topology) #2405

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Adding placement_policy for GKE nodepools (ex: GPU compact placement or TPU topology) #2405

merged 10 commits into from
Jul 3, 2024

Conversation

aurelienlegrand
Copy link
Collaborator

Adding placement_policy for GKE nodepools (ex: GPU compact placement or TPU topology).

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@aurelienlegrand aurelienlegrand requested a review from ludoo July 2, 2024 19:37
@aurelienlegrand aurelienlegrand self-assigned this Jul 2, 2024
wiktorn
wiktorn approved these changes Jul 3, 2024
View reviewed changes
modules/gke-nodepool/main.tf Outdated Show resolved Hide resolved
@aurelienlegrand aurelienlegrand enabled auto-merge (squash) July 3, 2024 10:16
@aurelienlegrand aurelienlegrand merged commit 1f07cb7 into master Jul 3, 2024
13 checks passed
@aurelienlegrand aurelienlegrand deleted the gke-nodepools-tpu branch July 3, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@ludoo ludoo Awaiting requested review from ludoo

Assignees

@aurelienlegrand aurelienlegrand

Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aurelienlegrand @wiktorn @legranda-adeo