-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NCC in 2-net-a-simple #2397
NCC in 2-net-a-simple #2397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
For ncc we shouldn't need to be whitelisted, given it just went public preview. Anyway, the provider is not there yet.
Also, readme should be updated before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really linear and simple to read :)
This PR is tested and it works :)
This is why the PR is in draft. I'm updating the README as/if we reach consensus this is a valid PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now. I guess we can finalize this updating tests and readme and then merge.
Given there seems to be consensus, I'll go ahead and write docs/tests. |
terraform fmt
on all modified filestools/tfdoc.py
This is a first, basic implementation of NCC in 2-simple.
Caveats: