Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules/artifact-registry with newly-released features. #2396

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Jun 28, 2024

@juliocc juliocc merged commit 4e8adc9 into master Jun 28, 2024
13 checks passed
@juliocc juliocc deleted the jccb/ar-updates branch June 28, 2024 17:52
@shakeel
Copy link

shakeel commented Jul 18, 2024

This PR breaks other terraform modules in Cloud Foundation Fabric, such as the blueprints/gke/patterns/autopilot-cluster which expects the registry to have image_path. This field was deleted in this PR.

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2396/files#diff-b40a1f2d7f7c111740c753eeca7968ba7bdb4539d40c111e5e57124662058094

@ludoo
Copy link
Collaborator

ludoo commented Jul 19, 2024

Thanks for flagging this, it looks like that blueprint has no tests, which is weird and why it was broken by the change. We'll send a fix shortly.

@juliocc
Copy link
Collaborator Author

juliocc commented Jul 19, 2024

@ludoo the gke patterns folder has no tests. Assign this to me and I'll fix it next week when I come back

@ludoo
Copy link
Collaborator

ludoo commented Jul 19, 2024

No worries, I can do it later :)

@ludoo
Copy link
Collaborator

ludoo commented Jul 20, 2024

@juliocc I'm going to revert the change that removed the registry URL from the outputs, I use it a lot as it saves me having to a) look for it in the docs, b) build it every time I use the module. It's what is breaking the blueprint BTW. I'm sure you had a reason for removing it, but it escapes me ATM. :)

@ludoo
Copy link
Collaborator

ludoo commented Jul 20, 2024

It's the equivalent to this in the UI

image

@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifactory does not support generic
3 participants