Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssuredWorkload support to the folder module #2390

Merged
merged 20 commits into from
Jun 27, 2024

Conversation

averbuks
Copy link
Member

@averbuks averbuks commented Jun 26, 2024

Add AssuredWorkload support to the folder module

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@averbuks averbuks changed the title [WIP] Add AssuredWorkload support to the folder module Add AssuredWorkload support to the folder module Jun 26, 2024
@averbuks averbuks marked this pull request as ready for review June 26, 2024 23:44
@averbuks averbuks requested review from ludoo and sruffilli June 26, 2024 23:45
modules/folder/main.tf Outdated Show resolved Hide resolved
modules/folder/main.tf Outdated Show resolved Hide resolved
modules/folder/main.tf Outdated Show resolved Hide resolved
modules/folder/main.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aleks! 👍 to Wiktor's comments, then it's good from my side.

modules/folder/README.md Outdated Show resolved Hide resolved
modules/folder/README.md Show resolved Hide resolved
modules/folder/README.md Outdated Show resolved Hide resolved
modules/folder/variables.tf Show resolved Hide resolved
wiktorn and others added 7 commits June 27, 2024 09:41
This example requires Access Transparency enabled on org level, even
chosing different regime, we need to have `parent` and `organization`
within the same hierarchy, which is not currently the case and requires
more rework of the test framework.
@averbuks averbuks merged commit 85c1b7c into master Jun 27, 2024
13 checks passed
@averbuks averbuks deleted the assured-worklod-folder branch June 27, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants