Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added certificate-manager module #2387

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Added certificate-manager module #2387

merged 2 commits into from
Jun 27, 2024

Conversation

apichick
Copy link
Collaborator

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also link it from top-level and modules-level READMEs?

juliocc
juliocc approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments. Thanks @apichick!

modules/certificate-manager/variables.tf Show resolved Hide resolved
@apichick apichick force-pushed the certificate-manager branch from 91ecd6f to d1ce51a Compare June 27, 2024 12:23
@apichick apichick enabled auto-merge (squash) June 27, 2024 12:54
@apichick apichick merged commit 00d4673 into master Jun 27, 2024
13 checks passed
@apichick apichick deleted the certificate-manager branch June 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apichick @ludoo @juliocc