Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apigee - Add forward_proxy_uri support on environment resource #2370

Conversation

diogo-j-n-teixeira
Copy link
Contributor

@diogo-j-n-teixeira diogo-j-n-teixeira commented Jun 20, 2024

Problem:

Apigee now support the use of an Forward Proxy. That configuration is at environment level, and the Terraform resource already have the ability of use it. However, this Apigee module don't.

Solution:

Add the argument forward_proxy_uri. This was tested, and the behavior is:

  • Having null"" or no definition of the forward_proxy_uri argument is the same for the provider, so no change/drift is raised
  • If you pass {scheme}://{hostname}:{port} TF will update the resource

Documentation:

  • Use of forward proxy - Here
  • Rest API - Here
  • Terraform resource - Here

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Jun 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@diogo-j-n-teixeira diogo-j-n-teixeira force-pushed the diogo-j-n-teixeira/apigee-env-flag branch from b6ba49d to 7a7f7ed Compare June 20, 2024 20:01
@ludoo ludoo requested a review from apichick June 25, 2024 07:37
@ludoo ludoo enabled auto-merge (squash) June 25, 2024 07:40
@ludoo ludoo merged commit 08ff364 into GoogleCloudPlatform:master Jun 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants