Support GCS objects in cloud function modules bundles #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
added
the
incompatible change
juliocc
approved these changes
Jun 14, 2024
albertogeniola
pushed a commit
to albertogeniola/cloud-foundation-fabric
that referenced
this pull request
Jun 19, 2024
…tform#2361) * cloud function v2 * cloud function v1 * blueprints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue when multiple cloud functions use the same bundle with different entrypoints, and our Cloud Function modules have to upload the same bundle for each individual function.
This PR makes GCS object URIs directly usable as bundles, and reinforces validation for the existing bundle types (local zip archive or folder).