Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing validation values for backend services #2351

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

deanosaurx
Copy link
Contributor


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Since I only added missing validation values I don't see the need to regenerate docs, it won't do anything. (You can correct me if I'm wrong). By the way, there might be additional modules with the same issue, I haven't got around to use them yet so you might hear from me again soon.

Cheers 👍

Copy link

google-cla bot commented Jun 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@ludoo
Copy link
Collaborator

ludoo commented Jun 9, 2024

Can you sign the CLA?

@deanosaurx
Copy link
Contributor Author

Signed :)

@ludoo ludoo enabled auto-merge (squash) June 9, 2024 07:07
@ludoo ludoo merged commit b9f20d4 into GoogleCloudPlatform:master Jun 9, 2024
9 checks passed
albertogeniola pushed a commit to albertogeniola/cloud-foundation-fabric that referenced this pull request Jun 19, 2024
@deanosaurx deanosaurx deleted the patch-1 branch June 23, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants