Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCVE Logging and Monitoring Blueprint #2347

Merged
merged 35 commits into from
Jun 11, 2024
Merged

Add GCVE Logging and Monitoring Blueprint #2347

merged 35 commits into from
Jun 11, 2024

Conversation

KonradSchieban
Copy link
Collaborator


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped a few comments on variable design

blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
@KonradSchieban KonradSchieban requested a review from ludoo June 7, 2024 11:38
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use modules whenever possible

blueprints/gcve/monitoring/main.tf Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/main.tf Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/main.tf Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Show resolved Hide resolved
blueprints/gcve/monitoring/README.md Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/main.tf Outdated Show resolved Hide resolved
blueprints/gcve/monitoring/main.tf Show resolved Hide resolved
blueprints/gcve/monitoring/variables.tf Show resolved Hide resolved
blueprints/gcve/monitoring/variables.tf Show resolved Hide resolved
@KonradSchieban KonradSchieban requested review from ludoo and juliocc June 10, 2024 11:03
@KonradSchieban KonradSchieban requested a review from ludoo June 10, 2024 18:47
@KonradSchieban KonradSchieban enabled auto-merge (squash) June 11, 2024 14:33
@KonradSchieban KonradSchieban merged commit 330fe00 into master Jun 11, 2024
13 checks passed
@KonradSchieban KonradSchieban deleted the gcve-mon2 branch June 11, 2024 14:36
albertogeniola pushed a commit to albertogeniola/cloud-foundation-fabric that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants