Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outstanding checks from lint.sh to pre-commit #2327

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented May 30, 2024

  • versions
  • validate metadata
  • check names
  • check links

check-links takes a shortcut and if change is done in root directory, all files are checked (which takes a few seconds), otherwise it should be fairly quick.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

* versions
* validate metadata
* check names
* check links
@github-actions github-actions bot added the on:tools New or changed tool label May 30, 2024
@juliocc juliocc enabled auto-merge (squash) May 31, 2024 10:12
@juliocc juliocc merged commit 49c1d60 into master May 31, 2024
13 checks passed
@juliocc juliocc deleted the wiktorn-pre-commit branch May 31, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants