Add pre-commit hook configuration #2326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this for those who are forgetful as me, to run
terraform fmt
ortools/tfdoc.py
on changed files.As of now configuration includes following linters.
The checks that are raising most issues in our repo are:
Out of those, only shellcheck requires manual fixes, all other 3 above just apply the fix themselves. Shellcheck is controversial so we may want to disable it.
If you want to check the changes the linters introduce run
pre-commit run -a
to see all effect on the whole repo. When installed, pre-commit hook runs only on changed files in the commit.Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py