Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit YAPF style #2314

Merged
merged 1 commit into from
May 28, 2024
Merged

Explicit YAPF style #2314

merged 1 commit into from
May 28, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented May 28, 2024

Move the yapf style definition out of command line call into dedicated file.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@github-actions github-actions bot added the on:tools New or changed tool label May 28, 2024
ludoo
ludoo approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only comment is why did it take us so long to do this? :)

@wiktorn wiktorn enabled auto-merge (rebase) May 28, 2024 08:46
@wiktorn wiktorn merged commit cf31d83 into master May 28, 2024
13 checks passed
@wiktorn wiktorn deleted the wiktorn-lint-yapf branch May 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo