Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Alloydb E2E tests #2312

Merged
merged 4 commits into from
May 29, 2024
Merged

Fixes for Alloydb E2E tests #2312

merged 4 commits into from
May 29, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented May 28, 2024

Failures

  • too long project name in Sipmle example resulted in:
Error: "***-alloydb-prj" name must be 4 to 30 characters with lowercase and uppercase letters, numbers, hyphen, single-quote, double-quote, space, and exclamation point.
  • using self_link resulted in:
Error: Error creating Cluster: googleapi: Error 499: malformed network path: "https://www.googleapis.com/compute/v1/projects/***/global/networks/e2e-test"
  • Cross region replication stil fails with:
│ Error: Error creating cluster. Can not create secondary cluster without secondary_config field.
│
│   with module.alloydb.google_alloydb_cluster.secondary[0],
│   on /usr/local/google/home/wiktorn/git/cloud-foundation-fabric/modules/alloydb/main.tf line 199, in resource "google_alloydb_cluster" "secondary":
│  199: resource "google_alloydb_cluster" "secondary" {
  • Custom flags and users definition:
Error: Error creating User: googleapi: Error 400: Invalid resource state for "projects/364296783266/locations/europe-west4/clusters/primary": primary instance is not found  
  • Non empty plan after apply (for Simple example)
  # module.alloydb.google_alloydb_cluster.primary will be updated in-place
  ~ resource "google_alloydb_cluster" "primary" {
      + display_name           = "db"
        id                     = "projects/***/locations/europe-west4/clusters/db"
        name                   = "projects/***/locations/europe-west4/clusters/db"
        # (20 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.alloydb.google_alloydb_instance.primary will be updated in-place
  ~ resource "google_alloydb_instance" "primary" {
        id                    = "projects/***/locations/europe-west4/clusters/db/instances/db"
        name                  = "projects/***/locations/europe-west4/clusters/db/instances/db"
        # (19 unchanged attributes hidden)

      + network_config {
          + enable_public_ip = false
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

* too long project name in Sipmle example resulted in:
```
Error: "***-alloydb-prj" name must be 4 to 30 characters with lowercase and uppercase letters, numbers, hyphen, single-quote, double-quote, space, and exclamation point.
```

* using self_link resulted in:
```
Error: Error creating Cluster: googleapi: Error 499: malformed network path: "https://www.googleapis.com/compute/v1/projects/***/global/networks/e2e-test"
```

* Cross region replication stil fails with:
```
│ Error: Error creating cluster. Can not create secondary cluster without secondary_config field.
│
│   with module.alloydb.google_alloydb_cluster.secondary[0],
│   on /usr/local/google/home/wiktorn/git/cloud-foundation-fabric/modules/alloydb/main.tf line 199, in resource "google_alloydb_cluster" "secondary":
│  199: resource "google_alloydb_cluster" "secondary" {
```
@wiktorn wiktorn force-pushed the wiktorn-alloydb-e2e-fix branch from ab832ec to cb5aea4 Compare May 28, 2024 13:55
@juliocc juliocc enabled auto-merge (squash) May 29, 2024 14:36
@juliocc juliocc merged commit d1ec3b0 into master May 29, 2024
13 checks passed
@juliocc juliocc deleted the wiktorn-alloydb-e2e-fix branch May 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants