Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge FAST C and E network stages into a new B stage. #2309

Merged
merged 13 commits into from
May 28, 2024

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented May 27, 2024

This PR merges 2-networking-e-nva-bgp into 2-networking-c-nva to reduce our code footprint and improve maintainability.

  • Align and merge 2-networking-e-nva-bgp into 2-networking-c-nva
  • Update tests
  • Update README.md
  • Update references to 2-networking-e-nva-bgp to point to 2-networking-c-nva

@sruffilli sruffilli changed the title Merge FAST E network stage into C. Needs docuwork. Merge FAST E network stage into C. May 27, 2024
@sruffilli sruffilli marked this pull request as ready for review May 27, 2024 13:16
@sruffilli sruffilli added the incompatible change Pull request that breaks compatibility with previous version label May 27, 2024
@sruffilli sruffilli requested review from LucaPrete and ludoo May 27, 2024 13:22
Copy link
Member

@LucaPrete LucaPrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @sruffilli I'd wait to merge this before

  • we merge the two folders into a common b folder
  • we make sure the new readme has updated info in the "how to run this stage" section

@sruffilli
Copy link
Collaborator Author

As discussed with @sruffilli I'd wait to merge this before

  • we merge the two folders into a common b folder
  • we make sure the new readme has updated info in the "how to run this stage" section

Done

@sruffilli sruffilli requested a review from LucaPrete May 28, 2024 09:59
@LucaPrete LucaPrete requested a review from juliocc May 28, 2024 15:25
@sruffilli sruffilli changed the title Merge FAST E network stage into C. Merge FAST C and E network stages into a new B stage. May 28, 2024
@sruffilli sruffilli merged commit 532f1ec into master May 28, 2024
13 checks passed
@sruffilli sruffilli deleted the sruffilli/fast-c-e-merge branch May 28, 2024 15:27
@ludoo
Copy link
Collaborator

ludoo commented May 28, 2024

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:FAST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants