-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge FAST C and E network stages into a new B stage. #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruffilli
changed the title
Merge FAST E network stage into C. Needs docuwork.
Merge FAST E network stage into C.
May 27, 2024
juliocc
reviewed
May 27, 2024
sruffilli
added
the
incompatible change
Pull request that breaks compatibility with previous version
label
May 27, 2024
LucaPrete
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @sruffilli I'd wait to merge this before
- we merge the two folders into a common b folder
- we make sure the new readme has updated info in the "how to run this stage" section
Done |
LucaPrete
approved these changes
May 28, 2024
sruffilli
changed the title
Merge FAST E network stage into C.
Merge FAST C and E network stages into a new B stage.
May 28, 2024
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
2-networking-e-nva-bgp
into2-networking-c-nva
to reduce our code footprint and improve maintainability.2-networking-e-nva-bgp
into2-networking-c-nva
2-networking-e-nva-bgp
to point to2-networking-c-nva