Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: Cleanup/harmonization of Simple and NVA net stages #2287

Merged
merged 13 commits into from
May 16, 2024

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented May 16, 2024

This PR aligns 2-networking-a-simple and 2-networking-c-nva to

  • harmonize resource names and configurations
  • smooth going back and forth from one design to the other

... and is propedeutic to a potential unification of 2-networking-c-nva and 2-networking-e-nva-bgp

@sruffilli sruffilli changed the title Cleanup/harmonization of Simple and NVA stages FAST: Cleanup/harmonization of Simple and NVA net stages May 16, 2024
@sruffilli sruffilli added the incompatible change Pull request that breaks compatibility with previous version label May 16, 2024
@sruffilli sruffilli marked this pull request as ready for review May 16, 2024 09:54
@sruffilli sruffilli requested review from ludoo, juliocc and LucaPrete May 16, 2024 10:04
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sruffilli sruffilli merged commit 21f3b73 into master May 16, 2024
13 checks passed
@sruffilli sruffilli deleted the sruffilli/fast-nva-cleanup branch May 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:FAST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants