Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New alloydb module #2285

Merged
merged 12 commits into from
May 22, 2024
Merged

New alloydb module #2285

merged 12 commits into from
May 22, 2024

Conversation

simonebruzzechesse
Copy link
Collaborator

New alloydb module with cross region replication support

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@simonebruzzechesse simonebruzzechesse marked this pull request as draft May 15, 2024 11:08
@github-actions github-actions bot added the on:tools New or changed tool label May 17, 2024
@simonebruzzechesse simonebruzzechesse force-pushed the bruzz/alloydb branch 2 times, most recently from 0258ea0 to d65f3af Compare May 17, 2024 08:29
juliocc
juliocc requested changes May 17, 2024
View reviewed changes
modules/alloydb/README.md Outdated Show resolved Hide resolved
modules/alloydb/README.md Outdated Show resolved Hide resolved
modules/alloydb/main.tf Outdated Show resolved Hide resolved
modules/alloydb/main.tf Outdated Show resolved Hide resolved
modules/alloydb/main.tf Show resolved Hide resolved
modules/alloydb/main.tf Outdated Show resolved Hide resolved
modules/alloydb/outputs.tf Outdated Show resolved Hide resolved
@simonebruzzechesse simonebruzzechesse marked this pull request as ready for review May 17, 2024 12:36
LucaPrete
LucaPrete previously requested changes May 20, 2024
View reviewed changes
modules/alloydb/README.md Outdated Show resolved Hide resolved
modules/alloydb/README.md Outdated Show resolved Hide resolved
modules/alloydb/README.md Show resolved Hide resolved
modules/alloydb/main.tf Outdated Show resolved Hide resolved
modules/alloydb/main.tf Outdated Show resolved Hide resolved
modules/alloydb/outputs.tf Outdated Show resolved Hide resolved
modules/alloydb/outputs.tf Show resolved Hide resolved
modules/alloydb/variables.tf Outdated Show resolved Hide resolved
@ludoo ludoo dismissed LucaPrete’s stale review May 22, 2024 06:15

changes done

@simonebruzzechesse simonebruzzechesse merged commit 1e149c1 into master May 22, 2024
13 checks passed
@simonebruzzechesse simonebruzzechesse deleted the bruzz/alloydb branch May 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@ludoo ludoo ludoo approved these changes

@LucaPrete LucaPrete LucaPrete left review comments

Assignees
No one assigned
Labels
on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonebruzzechesse @ludoo @juliocc @LucaPrete