Unify VPN and Peering FAST stages #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't particularly like the name 2-networking-a-simple but I ruled out everything else that came to my mind, so open to suggestions. |
It works, and names can always be changed later :) |
ludoo
approved these changes
May 16, 2024
sruffilli
added
the
incompatible change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2-networking-a-peering and 2-networking-b-vpn are basically identical, with the only difference being how spokes are connected to the hub.
This PR unifies the two stages into 2-networking-a-simple, where the spoke connectivity method is controlled by variable spoke_configs, which allows a user to easily toggle between peerings (default) and VPNs.