Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud function CMEK key support #2270

Merged
merged 7 commits into from
May 14, 2024

Conversation

luigi-bitonti
Copy link
Contributor

With this PR cloud function source code encryption with CMEK key has been introduced.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution - looks very good. Do you mind adding support for CMEK also to Cloud Functions v2?

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments on variable descriptions, many thanks for this!

modules/cloud-function-v1/variables.tf Outdated Show resolved Hide resolved
modules/cloud-function-v1/variables.tf Outdated Show resolved Hide resolved
modules/cloud-function-v2/variables.tf Show resolved Hide resolved
@ludoo ludoo enabled auto-merge (squash) May 14, 2024 12:46
@ludoo ludoo merged commit a14ed9a into GoogleCloudPlatform:master May 14, 2024
9 checks passed
@luigi-bitonti luigi-bitonti deleted the cloud-function branch May 14, 2024 14:02
sruffilli pushed a commit that referenced this pull request May 15, 2024
* Added support to kms key

* Updated doc

* Fix variable description.

* Updated README

* Cloud function v2 integration with kms

* Fix variables description

---------

Co-authored-by: Ludovico Magnocavallo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants