-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudSQL PSC Endpoints support #2242
Conversation
e55ee06
to
903d9b5
Compare
I'm not so sure I like having the creation of the PSC endpoints in this module. Are we going to add PSC endpoint management to every product that supports it (e.g. GKE, Apigee, etc)? Personally I'd prefer keeping this module just setting the allowed PSC consumer projects and leaving the creation of the endpoints to the consumer. Having said that, PSC creation is becoming common enough that I can see the use of a |
100% agree, endpoints are conceptually part of the Plus, this would avoid integrating them everywhere as more more products start offering support, like Julio noted above. |
8b597f3
to
843f43a
Compare
843f43a
to
d72254b
Compare
I really liked the idea of adding that to This PR is now a bit split-brained, between E2E tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits, great PR
446ea07
to
a2f69b8
Compare
1e5c1d4
to
3f8ebdc
Compare
* Add PSC endpoints consumers to net-address * Cloud SQL E2E tests
Add PSC Endpoints to net-address. Simplifies creation of the PSC endpoint for any PSC supporting resource.
Additional changes:
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py